# Request for review on PR/issue

**URL:** https://forum.crystal-lang.org/t/request-for-review-on-pr-issue/1484
**Category:** Crystal Contrib
**Created:** [December 13, 2019, 4:52am UTC](https://forum.crystal-lang.org/t/request-for-review-on-pr-issue/1484 "2019-12-13T04:52:23Z")
**Posts on this page:** 8
**Page:** 1

<div class="post-metadata">

### Author: ![rogerdpack](https://yyz2.discourse-cdn.com/flex036/user_avatar/forum.crystal-lang.org/rogerdpack/32/117_2.png) [@rogerdpack](https://forum.crystal-lang.org/u/rogerdpack)
#### Post date: [December 13, 2019, 4:52am UTC](https://forum.crystal-lang.org/t/request-for-review-on-pr-issue/1484/1 "2019-12-13T04:52:23Z")

</div>

Got a PR or issue where you’ve responded to all feedback and (waited 72 hours and then) didn’t get a response. Add to this thread to get some more eyes on it! :) If that doesn’t work after 72 hours, add a comment to the PR (ex: “ready for review”). Rinse and repeat… :)

---

<div class="post-metadata">

### Author: ![rogerdpack](https://yyz2.discourse-cdn.com/flex036/user_avatar/forum.crystal-lang.org/rogerdpack/32/117_2.png) [@rogerdpack](https://forum.crystal-lang.org/u/rogerdpack)
#### Post date: [December 13, 2019, 4:52am UTC](https://forum.crystal-lang.org/t/request-for-review-on-pr-issue/1484/2 "2019-12-13T04:52:32Z")

</div>

Here’s one: [https://github.com/crystal-lang/crystal/pull/8499](https://github.com/crystal-lang/crystal/pull/8499)

---

<div class="post-metadata">

### Author: ![wontruefree](https://yyz2.discourse-cdn.com/flex036/user_avatar/forum.crystal-lang.org/wontruefree/32/1467_2.png) [@wontruefree](https://forum.crystal-lang.org/u/wontruefree)
#### Post date: [December 13, 2019, 11:17pm UTC](https://forum.crystal-lang.org/t/request-for-review-on-pr-issue/1484/3 "2019-12-13T23:17:12Z")

</div>

I totally agree I have had a few PRs out for a while. The core team is small and tries to commit code as well as review all the PRs that are out there. there are a few core team members that I have not seen in a while so the reviews might go slower.

---

<div class="post-metadata">

### Author: ![rogerdpack](https://yyz2.discourse-cdn.com/flex036/user_avatar/forum.crystal-lang.org/rogerdpack/32/117_2.png) [@rogerdpack](https://forum.crystal-lang.org/u/rogerdpack)
#### Post date: [December 18, 2019, 7:06pm UTC](https://forum.crystal-lang.org/t/request-for-review-on-pr-issue/1484/4 "2019-12-18T19:06:25Z")

</div>

In my perfect world, generating a PR could have a “template” (like issues do) to tell people what to expect, how to act as things happen, etc…if github even allows that [?], like “if no response from core within 72 hours, leave another comment!” or what have you :)

---

<div class="post-metadata">

### Author: ![wontruefree](https://yyz2.discourse-cdn.com/flex036/user_avatar/forum.crystal-lang.org/wontruefree/32/1467_2.png) [@wontruefree](https://forum.crystal-lang.org/u/wontruefree)
#### Post date: [December 20, 2019, 12:00am UTC](https://forum.crystal-lang.org/t/request-for-review-on-pr-issue/1484/5 "2019-12-20T00:00:06Z")

</div>

I think github uses your last commit message to seed your PR template which is not ideal. We could make a bot to post things for people but I feel like that could be a fair amount of work I would not want someone from the core team to spend time on that over the compiler. Unless they wanted too.

---

<div class="post-metadata">

### Author: ![rogerdpack](https://yyz2.discourse-cdn.com/flex036/user_avatar/forum.crystal-lang.org/rogerdpack/32/117_2.png) [@rogerdpack](https://forum.crystal-lang.org/u/rogerdpack)
#### Post date: [December 29, 2019, 4:44am UTC](https://forum.crystal-lang.org/t/request-for-review-on-pr-issue/1484/6 "2019-12-29T04:44:58Z")

</div>

Here’s a PR that could use some attention, thanks!

> <https://github.com/crystal-lang/crystal-book/pull/374>

---

<div class="post-metadata">

### Author: ![nono](https://yyz2.discourse-cdn.com/flex036/user_avatar/forum.crystal-lang.org/nono/32/675_2.png) [@nono](https://forum.crystal-lang.org/u/nono)
#### Post date: [December 31, 2019, 10:15am UTC](https://forum.crystal-lang.org/t/request-for-review-on-pr-issue/1484/7 "2019-12-31T10:15:30Z")

</div>

GitHub repositories can have a template for pull requests. You can see an example here: [https://github.com/github/gitignore/blob/master/.github/PULL\_REQUEST\_TEMPLATE.md](https://github.com/github/gitignore/blob/master/.github/PULL_REQUEST_TEMPLATE.md)

---

<div class="post-metadata">

### Author: ![rogerdpack](https://yyz2.discourse-cdn.com/flex036/user_avatar/forum.crystal-lang.org/rogerdpack/32/117_2.png) [@rogerdpack](https://forum.crystal-lang.org/u/rogerdpack)
#### Post date: [February 26, 2020, 3:43am UTC](https://forum.crystal-lang.org/t/request-for-review-on-pr-issue/1484/8 "2020-02-26T03:43:39Z")

</div>

Here’s a couple PR’s that could use review:

> <https://github.com/crystal-lang/crystal-book/pull/386>

> <https://github.com/crystal-lang/crystal-book/pull/389>

Thanks!
