The Crystal Programming Language Forum

Website updates, missing link, needed

While looking at the website homepage I found the link under the MACROS section gives a 404 Missing Page error.

It probably should be this:

https://crystal-lang.org/reference/syntax_and_semantics/macros/index.html

Also, under the SYNTAX section at the top, the link under it

https://crystal-lang.org/reference/getting_started/

shows for the cli command $ crystal --version old 0.36.1.
Probably good idea to update to current, to not confuse people what’s the latest.

1 Like

Yes, https://crystal-lang.org/reference/syntax_and_semantics/macros.html should be a redirect to https://crystal-lang.org/reference/syntax_and_semantics/macros/index.html.

I don’t know why those README.md targets no longer work. Do we need to replace them with index.html? @oprypin any idea?

I’ve created a PR to update version in crystal-book (Update crystal-version by straight-shoota · Pull Request #533 · crystal-lang/crystal-book · GitHub) and
added instructions to update crystal version in the book to the release checklist (Improve release checklist by straight-shoota · Pull Request #107 · crystal-lang/distribution-scripts · GitHub).

I confirm this finding - redirects are broken.

.venv/bin/pip install -U mkdocs-redirects==1.0.2
make clean; make build
<!doctype html>
<html lang="en">
<head>
    <meta charset="utf-8">
    <title>Redirecting...</title>
    <link rel="canonical" href="macros/README.html">
    <meta name="robots" content="noindex">
    <script>var anchor=window.location.hash.substr(1);location.href="macros/README.html"+(anchor?"#"+anchor:"")</script>
    <meta http-equiv="refresh" content="0; url=macros/README.html">
</head>
<body>
Redirecting...
</body>
</html>
.venv/bin/pip install -U mkdocs-redirects==1.0.1
make clean; make build
<!doctype html>
<html lang="en">
<head>
    <meta charset="utf-8">
    <title>Redirecting...</title>
    <link rel="canonical" href="/reference/syntax_and_semantics/macros/index.html">
    <meta name="robots" content="noindex">
    <script>var anchor=window.location.hash.substr(1);location.href="/reference/syntax_and_semantics/macros/index.html"+(anchor?"#"+anchor:"")</script>
    <meta http-equiv="refresh" content="0; url=/reference/syntax_and_semantics/macros/index.html">
</head>
<body>
Redirecting...
</body>
</html>
1 Like