Hey guys, some of you might have already noticed a delay in merging approved PRs lately. The idea is to ensure more stability and give more chances for additional reviewers to take a look at the proposed changes.
As before, a pull request still needs green CI and two approvals from core team members (one if the author is a member) to be accepted. Once accepted, it is added to the current milestone. But we won’t directly merge it on master. The milestoning signals the PR is scheduled to be merged soon and gives everyone a last chance for comments. The wait time is suppposed to be about a day at minimum but may depend on the gravity of the change. So please don’t ping every core team member 24 hours after the milestone was added. But feel free to bump the PR if a reasonable amount of time has passed without reactions.
This process is a guideline and not a strict rule so there might be occassional exceptions within reason. Urgent infrastructure fixes for example should be expected to skip the line.