Reviewer/approver for changes to crystal-community/toml.cr

Crystal Contrib
1

G’day,

I noticed the other day that toml.cr could do with a bit of love and so I’ve spent some time improving it a little:

I’d like to bring this up to the standard of the JSON and YAML libraries in the stdlib, especially adding a TOML::Serializable module to parse directly to objects, as well as making the parser compliant with TOML v1.0.0.

Does someone with write permissions to this repo have some time to review these changes?

2 Likes
2

I believe @asterite (Ary Borenszweig) is the main maintainer :slight_smile:

@bcardiff Brian, can you help on this?

3

I wouldn’t expect either to be active; it’s in crystal-community’s hand now. @willhbr perhaps you can ask a moderator of crystal-community to add you as maintainer?

1 Like
4

Latest release was by @veelenga . Unless there is any objections and if @willhbr wants to be a maintainer, I should be able to grant him access to the repo.

1 Like
5

I’m happy to take maintainer powers, I promise I’ll be responsible :slight_smile:

3 Likes
6

I was wrong, I don’t have owner access in that organization. @veelenga or benoist are the ones that can do that.

If there is no response I can merge the PRs at least.

7

Thanks @bcardiff and @veelenga :slight_smile:

Will leave those larger PRs open for a bit in case anyone wants to do a drive-by review.

I think I’ve worked out a nice way of deserialising directly to objects, hoping to get that implemented soon.

2 Likes